linux-kernel - Re: [PATCH] clk: ti: dra7xx: Reset the mcasp3_ahclkx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26063901-be4f-dbe3-514b-e9a1a8ab3b10@ti.com>
Date:   Wed, 6 Sep 2017 14:42:31 +0300
From:   Tero Kristo <t-kristo@...com>
To:     Keerthy <j-keerthy@...com>, <sboyd@...eaurora.org>
CC:     <linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <tony@...mide.com>
Subject: Re: [PATCH] clk: ti: dra7xx: Reset the mcasp3_ahclkx_mux clock value


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 06/09/17 13:36, Keerthy wrote:
> Reset the mcasp3_ahclkx_mux to abe_24m_fclk. This is needed
> in case of kexec where the reset values might be wiped off.
> 
> Signed-off-by: Keerthy <j-keerthy@...com>

Why not do this in DT with the assigned-clock-xyz properties available?

-Tero

> ---
>   drivers/clk/ti/clk-7xx.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index 9fd6043..2c3a36c 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -312,7 +312,7 @@
>   int __init dra7xx_dt_clk_init(void)
>   {
>   	int rc;
> -	struct clk *dpll_ck, *hdcp_ck;
> +	struct clk *dpll_ck, *hdcp_ck, *mcasp3_ahclkx_ck, *abe_ck;
>   
>   	ti_dt_clocks_register(dra7xx_clks);
>   
> @@ -338,5 +338,12 @@ int __init dra7xx_dt_clk_init(void)
>   	if (rc)
>   		pr_err("%s: failed to set dss_deshdcp_clk\n", __func__);
>   
> +	mcasp3_ahclkx_ck = clk_get_sys(NULL, "mcasp3_ahclkx_mux");
> +	abe_ck = clk_get_sys(NULL, "abe_24m_fclk");
> +	rc = clk_set_parent(mcasp3_ahclkx_ck, abe_ck);
> +	if (rc)
> +		pr_err("%s: failed to set parent for mcasp3_ahclkx_mux\n",
> +		       __func__);
> +
>   	return rc;
>   }
>