linux-kernel - Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170907094640.cbyqem5zysuoyshw@gmail.com>
Date:   Thu, 7 Sep 2017 11:46:40 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Andy Lutomirski <luto@...nel.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org, Brian Gerst <brgerst@...il.com>,
        Andrew Cooper <andrew.cooper3@...rix.com>,
        Juergen Gross <jgross@...e.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [RFC 01/17] x86/asm/64: Remove the restore_c_regs_and_iret label


* Borislav Petkov <bp@...en8.de> wrote:

> On Wed, Sep 06, 2017 at 02:36:46PM -0700, Andy Lutomirski wrote:
> > The only user was the 64-bit opportunistic SYSRET failure path, and
> > that path didn't really need it.  This change makes the
> > opportunistic SYSRET code a bit more straightforward and gets rid of
> > the label.
> > 
> > Signed-off-by: Andy Lutomirski <luto@...nel.org>
> > ---
> >  arch/x86/entry/entry_64.S | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> Btw, you need to refresh your stuff because of those UNWIND_HINT_EMPTY
> things. I get:
> 
> checking file arch/x86/entry/entry_64.S
> Hunk #1 succeeded at 245 (offset 5 lines).
> Hunk #2 FAILED at 308.
> Hunk #3 succeeded at 637 (offset 88 lines).
> 1 out of 3 hunks FAILED
> 
> Otherwise
> 
> Reviewed-by: Borislav Petkov <bp@...e.de>

I'd suggest tip:master or upstream 24e700e291d5 as a post-merge-window base for 
x86 bits.

Thanks,

	Ingo