linux-kernel - Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Added Space around binary op.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1709080802310.2161@hadrien>
Date:   Fri, 8 Sep 2017 08:04:18 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Himanshi Jain <himshijain.hj@...il.com>
cc:     outreachy-kernel@...glegroups.com, lars@...afoo.de,
        Michael.Hennerich@...log.com, jic23@...nel.org, knaack.h@....de,
        pmeerw@...erw.net, gregkh@...uxfoundation.org,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Added Space around
 binary op.



On Fri, 8 Sep 2017, Himanshi Jain wrote:

> Added space around(one on each side of) binary

I think that just around would be clear enough.

In the previous patches on this file, found with git log --oneline, a
subject line of staging: iio: ad7192: seems to be more popular when the
patch affects only this file.  But maybe it doesn't matter either way.

julia

> operator(-) as preferred according to kernel
> coding style.
>
> Signed-off-by: Himanshi Jain <himshijain.hj@...il.com>
> ---
>  drivers/staging/iio/adc/ad7192.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index d11c6de..1aee662 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -341,7 +341,7 @@ static int ad7192_setup(struct ad7192_state *st,
>  }
>
>  static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> -			     in_voltage-voltage_scale_available,
> +			     in_voltage - voltage_scale_available,
>  			     0444, ad7192_show_scale_available, NULL, 0);
>
>  static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170908044752.GA6199%40himanshi-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>