linux-kernel - Re: [PATCH] Staging: iio: adc: Added Space around binary op.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DEB4AC67-43D5-40F9-9495-DB4966A07661@jic23.retrosnub.co.uk>
Date:   Fri, 08 Sep 2017 07:29:06 +0100
From:   Jonathan Cameron <jic23@...23.retrosnub.co.uk>
To:     Himanshi Jain <himshijain.hj@...il.com>,
        outreachy-kernel@...glegroups.com, lars@...afoo.de,
        Michael.Hennerich@...log.com, jic23@...nel.org, knaack.h@....de,
        pmeerw@...erw.net, gregkh@...uxfoundation.org,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: iio: adc: Added Space around binary op.



On 8 September 2017 05:47:52 BST, Himanshi Jain <himshijain.hj@...il.com> wrote:
>Added space around(one on each side of) binary
>operator(-) as preferred according to kernel
>coding style.
>
>Signed-off-by: Himanshi Jain <himshijain.hj@...il.com>

Take a closer look at that macro. It isn't doing what you think...  To give a hint, changing this breaks userspace.

Jonathan


>---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/staging/iio/adc/ad7192.c
>b/drivers/staging/iio/adc/ad7192.c
>index d11c6de..1aee662 100644
>--- a/drivers/staging/iio/adc/ad7192.c
>+++ b/drivers/staging/iio/adc/ad7192.c
>@@ -341,7 +341,7 @@ static int ad7192_setup(struct ad7192_state *st,
> }
> 
> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
>-			     in_voltage-voltage_scale_available,
>+			     in_voltage - voltage_scale_available,
> 			     0444, ad7192_show_scale_available, NULL, 0);
> 
> static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.