linux-kernel - Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170908080729.GT2477@lahna.fi.intel.com>
Date:   Fri, 8 Sep 2017 11:07:29 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Mario Limonciello <mario.limonciello@...l.com>
Cc:     dvhart@...radead.org, LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        Richard Hughes <hughsient@...il.com>,
        Yehezkel Bernat <yehezkelshb@...il.com>
Subject: Re: [PATCH v2] Add driver to force WMI Thunderbolt controller power
 status

On Thu, Sep 07, 2017 at 01:47:22PM -0500, Mario Limonciello wrote:

I have a small comment which you might want to consider.

> +static int intel_wmi_thunderbolt_probe(struct wmi_device *wdev)
> +{
> +	return sysfs_create_group(&wdev->dev.kobj, &tbt_attribute_group);
> +}
> +
> +static int intel_wmi_thunderbolt_remove(struct wmi_device *wdev)
> +{
> +	sysfs_remove_group(&wdev->dev.kobj, &tbt_attribute_group);
> +	return 0;
> +}

In order to notify userspace about this, what if you send KOBJ_CHANGE
for the wdev when you add/remove this attribute?