linux-kernel - Re: [PATCH v2 1/3] ASoC: samsung: i2s: Use specific name for i2s dais

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Sep 2017 18:43:30 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Jaechul Lee <jcsing.lee@...sung.com>
Cc:     Sangbeom Kim <sbkim73@...sung.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        galaxyra@...il.com, Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH v2 1/3] ASoC: samsung: i2s: Use specific name for i2s dais

On Wed, Sep 06, 2017 at 10:04:13AM +0900, Jaechul Lee wrote:
> Add specific dais name when components are registered. Component and dai
> name will follow their parent dev name, if the name isn't described.  In
> case of this driver, each dais will have same name like '11440000.i2s0' by
> fmt_single_name function.
> 
> The problem having same name is that TM2 machine driver can't detect
> capture devices correctly. Machine driver doesn't know which one is proper
> to use for cpu dai. The driver just selects to use 'samsung-i2c-sec' that
> doesn't have capture functionality because the component of
> samsung-i2s-sec is located in the first of the component_list.
> 
> I add dai name like 'samsung-i2s', 'samsung-i2s-sec' for each dais. The
> reason why adding dai id to 1 is that it doesn't allow to use particular
> dai name in case of when I use 0 for dai id.
> 
> Signed-off-by: Jaechul Lee <jcsing.lee@...sung.com>
> ---
>  sound/soc/samsung/i2s.c | 4 ++++
>  sound/soc/samsung/i2s.h | 3 +++
>  2 files changed, 7 insertions(+)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof