linux-kernel - Re: [PATCH v2 2/3] ASoC: samsung: Use 'samsung-i2s' cpu_dai for dai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170908164512.5wwrn2gknfzzb6uy@kozik-lap>
Date:   Fri, 8 Sep 2017 18:45:12 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Jaechul Lee <jcsing.lee@...sung.com>
Cc:     Sangbeom Kim <sbkim73@...sung.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        galaxyra@...il.com, Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH v2 2/3] ASoC: samsung: Use 'samsung-i2s' cpu_dai for
 dai_links

On Wed, Sep 06, 2017 at 10:04:14AM +0900, Jaechul Lee wrote:
> Add specific cpu_dai_name to dai_link because samsung i2s driver registers
> two dais and components. Selecting one of them clearly is needed more
> information like cpu_dai_name, of_node. The reason why the dai_links have
> to use 'samsung-i2s' for cpu_dai is that 'samsung-i2s-sec' doesn't have a
> capture functionality.
> 
> Without this code, cpu_dai will be selected the first one of the
> component_list. For example, if I describe nothing to cpu_dai_name,
> 'samsung-i2s-sec' might be selected to HiFi Primay.
> 
> Signed-off-by: Jaechul Lee <jcsing.lee@...sung.com>
> ---
>  sound/soc/samsung/tm2_wm5110.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof