linux-kernel - RE: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <006201d32b0a$341b5470$9c51fd50$@opengridcomputing.com>
Date:   Mon, 11 Sep 2017 09:28:14 -0500
From:   "Steve Wise" <swise@...ngridcomputing.com>
To:     "'Colin King'" <colin.king@...onical.com>,
        "'Steve Wise'" <swise@...lsio.com>,
        "'Doug Ledford'" <dledford@...hat.com>,
        "'Sean Hefty'" <sean.hefty@...el.com>,
        "'Hal Rosenstock'" <hal.rosenstock@...il.com>,
        <linux-rdma@...r.kernel.org>
Cc:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp

> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> sqp is being initialised when it is being declared and then updated
> a little later on making the first initialization redundant. Clean
> this up by initializing ptr and sqp at their declaration.
> 
> Cleans up warning: "warning: Value stored to 'sqp' during its
> initialization is never read"
> 
> Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue pointer as
> needed on flush")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Steve Wise <swise@...ngridcomputing.com>