linux-kernel - Re: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1506517886.82712.9.camel@redhat.com>
Date:   Wed, 27 Sep 2017 09:11:26 -0400
From:   Doug Ledford <dledford@...hat.com>
To:     Colin King <colin.king@...onical.com>,
        Steve Wise <swise@...lsio.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        linux-rdma@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/cxgb3: remove redundant first assignement of sqp

On Mon, 2017-09-11 at 12:42 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> sqp is being initialised when it is being declared and then updated
> a little later on making the first initialization redundant. Clean
> this up by initializing ptr and sqp at their declaration.
> 
> Cleans up warning: "warning: Value stored to 'sqp' during its
> initialization is never read"
> 
> Fixes: a58e58fafdff ("RDMA/cxgb3: Wrap the software send queue
> pointer as needed on flush")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks, applied.

-- 
Doug Ledford <dledford@...hat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD