linux-kernel - Re: [PATCH v6] livepatch: introduce shadow variable API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e161216a-e82b-f89a-b177-3ab103993733@redhat.com>
Date:   Tue, 12 Sep 2017 18:11:00 -0400
From:   Joe Lawrence <joe.lawrence@...hat.com>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jessica Yu <jeyu@...hat.com>, Jiri Kosina <jikos@...nel.org>,
        Miroslav Benes <mbenes@...e.cz>, Petr Mladek <pmladek@...e.com>
Subject: Re: [PATCH v6] livepatch: introduce shadow variable API

On 09/12/2017 12:20 PM, Josh Poimboeuf wrote:
> On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote:
>> +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
>> +		       size_t size, gfp_t gfp_flags, bool warn_on_exist)
>> +{
>> +	struct klp_shadow *new_shadow;
>> +	void *shadow_data;
>> +	unsigned long flags;
>> +
>> +	/* Check if the shadow variable if <obj, id> already exists */
> 
> Grammar fix: either
> 
>   s/if the shadow variable//
> 
> or
> 
>   s/if <obj, id>//
> 
> Otherwise:
> 
> Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>
> 

If this is the only outstanding nit, can this be fixed up on merge or
does it need a new patch spin?

Thanks,

-- Joe