linux-kernel - Re: fs/select.c:991:1: warning: the frame size of 1032 bytes is larger than 1024 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Sep 2017 00:12:14 +0200
From:   Helge Deller <deller@....de>
To:     Meelis Roos <mroos@...ux.ee>
Cc:     linux-parisc@...r.kernel.org,
        Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: fs/select.c:991:1: warning: the frame size of 1032 bytes is
 larger than 1024 bytes

On 11.09.2017 22:16, Meelis Roos wrote:
>> Meelis, this patch should fix both issues.
>> Can you test?
> 
> At least one of the warnings is still there - but I am on a 64-bit
> kernel on RP3440, RP3410 and A500 where I saw this.

Details?
The ones you sent were 32bit issues (with 1024 bytes frame-size-warning):
fs/select.c:991:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]
arch/parisc/kernel/inventory.c:359:1: warning: the frame size of 1120 bytes is larger than 1024 bytes [-Wframe-larger-than=]

Helge


>>
>> Helge
>>
>> [PATCH] parisc: Fix too large frame size warnings
>>
>> The parisc architecture requires larger stack frames than most other
>> architectures on 32-bit kernels.
>> Increase the default to 1280 bytes for parisc to avoid warnings in
>> do_sys_poll() and pat_memconfig() functions.
>>
>> Signed-off-by: Helge Deller <deller@....de>
>>
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index b19c491cbc4e..2689b7c50c52 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -219,7 +219,8 @@ config FRAME_WARN
>>   	range 0 8192
>>   	default 0 if KASAN
>>   	default 2048 if GCC_PLUGIN_LATENT_ENTROPY
>> -	default 1024 if !64BIT
>> +	default 1280 if (!64BIT && PARISC)
>> +	default 1024 if (!64BIT && !PARISC)
>>   	default 2048 if 64BIT
>>   	help
>>   	  Tell gcc to warn at build time for stack frames larger than this.
>>
>