linux-kernel - Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1709130751380.4703@jbgna.fhfr.qr>
Date:   Wed, 13 Sep 2017 07:52:20 -0700 (PDT)
From:   Jiri Kosina <jikos@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Guenter Roeck <groeck@...omium.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: allocate hid buffers for real worst case

On Wed, 13 Sep 2017, Dmitry Torokhov wrote:

> > > From: Adrian Salido <salidoa@...gle.com>
> > > 
> > > The buffer allocation is not currently accounting for an extra byte for
> > > the report id. This can cause an out of bounds access in function
> > > i2c_hid_set_or_send_report() with reportID > 15.
> > > 
> > > Signed-off-by: Guenter Roeck <groeck@...omium.org>
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > 
> > Missing signoff from the patch author?
> 
> Oops, I must have cut it off on accident while removing ChromeOS
> specific tags, the original commit is here:
> 
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/475212

Ok, thanks, will use that one. How about 

	Reviewed-by: Benson Leung <bleung@...omium.org>

which is missing in the mail you've sent, but is there in the above 
reference commit?

> > Also, I think this should have Cc: stable, right?
> 
> I usually let maintainers decide, but yes.

I'll be adding it. Thanks,

-- 
Jiri Kosina
SUSE Labs