linux-kernel - Re: [PATCH] scsi: lpfc: remove redundant null check on eqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d36fb68-7997-cba7-8e27-5b28306e443c@broadcom.com>
Date:   Thu, 14 Sep 2017 07:47:59 -0700
From:   James Smart <james.smart@...adcom.com>
To:     Colin King <colin.king@...onical.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: remove redundant null check on eqe

On 9/8/2017 1:02 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The pointer eqe is always non-null inside the while loop, so the
> check to see if eqe is NULL is redudant and hence can be removed.
>
> Detected by CoverityScan CID#1248693 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>

Yep. thank you

Signed-off-by: James Smart <james.smart@...adcom.com>