linux-kernel - Re: [PATCH 2/3] selftests/intel_pstate: No need to compile test progs in the run script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e80355b9-1288-2e7d-a794-2ba3b8dcd1bb@kernel.org>
Date:   Thu, 14 Sep 2017 08:59:21 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Thomas Meyer <thomas@...3r.de>, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, Shuah Khan <shuah@...nel.org>
Cc:     Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH 2/3] selftests/intel_pstate: No need to compile test progs
 in the run script

On 09/08/2017 06:01 AM, Thomas Meyer wrote:
> Both test programs are being compiled by make, so no need to compile both
> programs in the runner script.
> This resolves an error when installing all selftests via make install
> and run them in a different environemnt.
> 
> Running tests in intel_pstate
> ========================================
> ./run.sh: line 35: gcc: command not found
> Problem compiling aperf.c.
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>
> ---
>  tools/testing/selftests/intel_pstate/run.sh | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
> index 7868c106b8b1..96878e44f465 100755
> --- a/tools/testing/selftests/intel_pstate/run.sh
> +++ b/tools/testing/selftests/intel_pstate/run.sh
> @@ -31,12 +31,6 @@ EVALUATE_ONLY=0
>  
>  max_cpus=$(($(nproc)-1))
>  
> -# compile programs
> -gcc aperf.c -Wall -D_GNU_SOURCE -o aperf  -lm
> -[ $? -ne 0 ] && echo "Problem compiling aperf.c." && exit 1
> -gcc -o msr msr.c -lm
> -[ $? -ne 0 ] && echo "Problem compiling msr.c." && exit 1
> -
>  function run_test () {
>  
>  	file_ext=$1
> 
Thanks for the patch. I will get this into 4.14-rc2 or rc3

thanks,
-- Shuah