linux-kernel - Re: [PATCH 1/1] Drivers: hv: vmbus: Fix rescind handling issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ingkulhp.fsf@vitty.brq.redhat.com>
Date:   Fri, 15 Sep 2017 15:42:10 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     kys@...hange.microsoft.com,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     Haiyang Zhang <haiyangz@...rosoft.com>, olaf@...fle.de,
        sthemmin@...rosoft.com, gregkh@...uxfoundation.org,
        jasowang@...hat.com, linux-kernel@...r.kernel.org,
        marcelo.cerri@...onical.com, apw@...onical.com,
        devel@...uxdriverproject.org, leann.ogasawara@...onical.com
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix rescind handling issues

Stephen Hemminger <stephen@...workplumber.org> writes:

> On Fri, 11 Aug 2017 10:03:59 -0700
> kys@...hange.microsoft.com wrote:
>
>> From: K. Y. Srinivasan <kys@...rosoft.com>
>> 
>> This patch handles the following issues that were observed when we are
>> handling racing channel offer message and rescind message for the same
>> offer:
>> 
>> 1. Since the host does not respond to messages on a rescinded channel,
>> in the current code, we could be indefinitely blocked on the vmbus_open() call.
>> 
>> 2. When a rescinded channel is being closed, if there is a pending interrupt on the
>> channel, we could end up freeing the channel that the interrupt handler would run on.
>> 
>> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
>> Reviewed-by: Dexuan Cui <decui@...rosoft.com>
>> Tested-by: Dexuan Cui <decui@...rosoft.com>
>
> This patch breaks re-initialization of the network device on MTU changes.
>
> Doing:
> 	# ip li set dev eth1 mtu 9000
>
> will hang in rndis_filter_add waiting for subchannel notification.
> This is likely because when the vmbus device is reopened the sub channels
> are not correctly created.  Not sure what is wrong with the patch, but my
> suspicion is that the close/rescind events are no longer being sent to the
> host.

I'm seeing the same issue, reverting the offending 

commit 6f3d791f300618caf82a2be0c27456edd76d5164
Author: K. Y. Srinivasan <kys@...rosoft.com>
Date:   Fri Aug 11 10:03:59 2017 -0700

    Drivers: hv: vmbus: Fix rescind handling issues

which made it upstream helps. Did you guys do some investigation here?
In case not I can take a look next week.

-- 
  Vitaly