linux-kernel - Re: [Outreachy kernel] [PATCH] staging: rtlwifi: delete double assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Sep 2017 15:42:24 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Harsha Sharma <harshasharmaiitr@...il.com>
cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: rtlwifi: delete double
 assignment



On Fri, 15 Sep 2017, Harsha Sharma wrote:

> Remove two adjacent assignments to the same location.
> In practice, many such occurences are intentional but
> this case don't seem to fall into that category.
> Done using following coccinelle semantic patch
>
> @@
> expression e1,e2,e3;
> @@
>
> (
>  (<+...e1++...+>)=e2;
> |
>  (<+...e1--...+>)=e2;
> |
>  (<+...++e1...+>)=e2;
> |
>  (<+...--e1...+>)=e2;
> |
> e1=e2;
> e1 = <+...e1...+>;
> |
> *e1=e2;
> *e1=e3;
> )
>
> Signed-off-by: Harsha Sharma <harshasharmaiitr@...il.com>
> ---
>  drivers/staging/rtlwifi/base.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
> index b88b0e8..68bd124 100644
> --- a/drivers/staging/rtlwifi/base.c
> +++ b/drivers/staging/rtlwifi/base.c
> @@ -1536,7 +1536,6 @@ u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx,
>  		/* EAPOL is seen as in-4way */
>  		rtlpriv->btcoexist.btc_info.in_4way = true;
>  		rtlpriv->btcoexist.btc_info.in_4way_ts = jiffies;
> -		rtlpriv->btcoexist.btc_info.in_4way_ts = jiffies;

For something like this, it can be useful to do a git blame on the lines.
If they were both introduced at the same time, it probably doesn't tell
you anything.  But if there was one and then someone explicitly introduced
another one, then there could have been some reason for doing that.

julia

>
>  		RT_TRACE(rtlpriv, (COMP_SEND | COMP_RECV), DBG_DMESG,
>  			 "802.1X %s EAPOL pkt!!\n", (is_tx) ? "Tx" : "Rx");
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505478887-1820-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>