linux-kernel - Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Sep 2017 16:16:57 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "shuwang@...hat.com" <shuwang@...hat.com>,
        "kashyap.desai@...adcom.com" <kashyap.desai@...adcom.com>,
        "shivasharan.srikanteshwara@...adcom.com" 
        <shivasharan.srikanteshwara@...adcom.com>,
        "sumit.saxena@...adcom.com" <sumit.saxena@...adcom.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "chuhu@...hat.com" <chuhu@...hat.com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "yizhan@...hat.com" <yizhan@...hat.com>,
        "megaraidlinux.pdl@...adcom.com" <megaraidlinux.pdl@...adcom.com>
Subject: Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

On Fri, 2017-09-15 at 13:21 +0800, shuwang@...hat.com wrote:
> @@ -4548,9 +4556,11 @@ megasas_free_fusion_context(struct megasas_instance *instance)
>  
>  		if (is_vmalloc_addr(fusion))
>  			vfree(fusion);
> -		else
> +		else {
> +			kmemleak_free(fusion);
>  			free_pages((ulong)fusion,
>  				instance->ctrl_context_pages);
> +		}
>  	}

Braces are still not balanced in the above code. This is something
checkpatch should have told you. Anyway:

Reviewed-by: Bart Van Assche <bart.vanassche@....com>