linux-kernel - Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170915180007.GA24045@infradead.org>
Date:   Fri, 15 Sep 2017 11:00:07 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     shuwang@...hat.com
Cc:     kashyap.desai@...adcom.com, sumit.saxena@...adcom.com,
        shivasharan.srikanteshwara@...adcom.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, megaraidlinux.pdl@...adcom.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        chuhu@...hat.com, yizhan@...hat.com, catalin.marinas@....com
Subject: Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

I think the megaraid fusion code has a deeper problem here.

Instead of playing weird games with get_free_pages and vmalloc
the structure just needs to shrink by moving all the arrays
of MAX_MSIX_QUEUES_FUSION size into a separate allocation for each,
and then we have normall, small kmalloc allocations.