linux-kernel - [PATCH v2 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ed077d98-24b6-717b-56b0-3adf64f5db37@zoho.com>
Date:   Sat, 16 Sep 2017 01:59:41 +0800
From:   zijun_hu <zijun_hu@...o.com>
To:     marc.zyngier@....com
Cc:     tglx@...utronix.de, jason@...edaemon.net, james.morse@....com,
        sudeep.holla@....com, linux-kernel@...r.kernel.org,
        zijun_hu@....com
Subject: [PATCH v2 1/1] irqchip/gicv3: iterate over possible CPUs by
 for_each_possible_cpu()

From: zijun_hu <zijun_hu@....com>

get_cpu_number() doesn't use existing helper to iterate over possible
CPUs, it will cause error in case of discontinuous @cpu_possible_mask
such as 0b11110001, such discontinuous @cpu_possible_mask is resulted
in likely because one core have failed to come up on a SMP machine

fixed by using existing helper for_each_possible_cpu().

Signed-off-by: zijun_hu <zijun_hu@....com>
---
 Changes in v2:
  - more detailed commit messages are offered

 drivers/irqchip/irq-gic-v3.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 519149ec9053..b5df99c6f680 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -1042,7 +1042,7 @@ static int get_cpu_number(struct device_node *dn)
 {
 	const __be32 *cell;
 	u64 hwid;
-	int i;
+	int cpu;
 
 	cell = of_get_property(dn, "reg", NULL);
 	if (!cell)
@@ -1056,9 +1056,9 @@ static int get_cpu_number(struct device_node *dn)
 	if (hwid & ~MPIDR_HWID_BITMASK)
 		return -1;
 
-	for (i = 0; i < num_possible_cpus(); i++)
-		if (cpu_logical_map(i) == hwid)
-			return i;
+	for_each_possible_cpu(cpu)
+		if (cpu_logical_map(cpu) == hwid)
+			return cpu;
 
 	return -1;
 }
-- 
1.9.1