linux-kernel - Re: [PATCH] Support new Alps HID Touchpad device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1709151719460.4703@jbgna.fhfr.qr>
Date:   Fri, 15 Sep 2017 17:27:23 -0700 (PDT)
From:   Jiri Kosina <jikos@...nel.org>
To:     Masaki Ota <012nexus@...il.com>
cc:     benjamin.tissoires@...hat.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, masaki.ota@...alps.com
Subject: Re: [PATCH] Support new Alps HID Touchpad device

On Tue, 12 Sep 2017, Masaki Ota wrote:

> This is the patch for support new Alps HID Touchpad device.
> I submitted these patch before, but it was not completed.
> So I separate the patch to some parts and release it again. 

Hi,

I have a few minor comments -- as in the past, I'd like to ask for 
improved changelogs, so that they are up to our kernel standards. As you 
are a regular contributor, it's time to start getting things right :)

Namely:

- please be generally more verbose / detailed in your changelogs
- explain not only what changes are being done, but also why they are 
  being done (what is the motivation). As an example, patch #1 has this:

	-To support Alps T4 device, clean up the source code
	-Delete unnecessary structure

  Please briefly document the cleanups, and also document which structure 
  is being removed and why it is redundant
- you can drop the repeating "Minor changes in hid-alps.c for support new 
  Alps device" prefix for the patche subjects, as it doesn't really 
  provide any extra information
- pathces #4 and #5 do quite a substantial changes to the code, it'd be 
  nice to describe in a few sentnces what are the changes (what are the 
  specifics of the new protocol, etc)

Thanks a lot!

-- 
Jiri Kosina
SUSE Labs