lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Sep 2017 11:06:55 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Guenter Roeck <linux@...ck-us.net> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Yueyao Zhu <yueyao@...gle.com>, Badhri Jagan Sridharan <badhri@...gle.com>, Hans de Goede <hdegoede@...hat.com>, linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org, linux-usb@...r.kernel.org Subject: Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code On Tue, Sep 12, 2017 at 09:41:20AM -0700, Guenter Roeck wrote: > On Tue, Sep 12, 2017 at 10:38:39AM +0300, Heikki Krogerus wrote: > > On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote: > > > Commented out code can be added as needed. Drop it. > > > Also drop TODO and an obsolete XXX comment. > > > > > > Signed-off-by: Guenter Roeck <linux@...ck-us.net> > > > --- > > > v2, v3: No change > > > > > > drivers/staging/typec/tcpm.c | 37 +------------------------------------ > > > 1 file changed, 1 insertion(+), 36 deletions(-) > > > > Nice! Just to be sure: The idea is to leave tcpci.c in staging, right? > > > Yes, until we get test coverage or Greg gets tired of keeping it there > (in that case we would probably have to drop it). Well, if it's not ever going to get fixed up, why can't we just drop it? Anyway, I've pulled this series into the staging and USB trees, so all should be good for it now. thanks, greg k-h
Powered by blists - more mailing lists