linux-kernel - Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1972340.u0BEiYTrvM@phil>
Date:   Mon, 18 Sep 2017 11:30:17 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     jeffy <jeffy.chen@...k-chips.com>
Cc:     Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
        dgreid@...omium.org, briannorris@...omium.org, mka@...omium.org,
        dianders@...omium.org, devicetree@...r.kernel.org,
        alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

Hi Jeffy,

Am Montag, 18. September 2017, 09:22:21 CEST schrieb jeffy:
> On 09/14/2017 01:24 AM, Rob Herring wrote:
> > On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote:
> >> diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt
> >> index 929ca6756b02..841a1159e234 100644
> >> --- a/Documentation/devicetree/bindings/sound/rt5514.txt
> >> +++ b/Documentation/devicetree/bindings/sound/rt5514.txt
> >> @@ -4,7 +4,7 @@ This device supports I2C only.
> >
> > SPI support should be added to this document.
> ok, will do.
> >
> >>
> >>   Required properties:
> >>
> >> -- compatible : "realtek,rt5514".
> >> +- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c".
> >
> > There's no need for the -spi or -i2c compatibles. This is implied by
> > being a child of those controllers.
> heiko mentioned i should add it in the binding in:
> https://patchwork.kernel.org/patch/9918987/

If you add a new compatible you need to add it to the binding. I think what
Rob means is, that both the i2c and spi side can have the _same_
compatible without the -i2c or -spi, as you can check wether they are
children of either a spi or i2c controller in the code itself.


Heiko