linux-kernel - Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59BFABE7.5050904@rock-chips.com>
Date:   Mon, 18 Sep 2017 19:20:07 +0800
From:   jeffy <jeffy.chen@...k-chips.com>
To:     Heiko Stuebner <heiko@...ech.de>
CC:     Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
        dgreid@...omium.org, briannorris@...omium.org, mka@...omium.org,
        dianders@...omium.org, devicetree@...r.kernel.org,
        alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for
 rt5514-spi

Hi Heiko,

Thanks for your reply.

On 09/18/2017 05:30 PM, Heiko Stuebner wrote:
>>>> > >>
>>>> > >>-- compatible : "realtek,rt5514".
>>>> > >>+- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c".
>>> > >
>>> > >There's no need for the -spi or -i2c compatibles. This is implied by
>>> > >being a child of those controllers.
>> >heiko mentioned i should add it in the binding in:
>> >https://patchwork.kernel.org/patch/9918987/
> If you add a new compatible you need to add it to the binding. I think what
> Rob means is, that both the i2c and spi side can have the_same_
> compatible without the -i2c or -spi, as you can check wether they are
> children of either a spi or i2c controller in the code itself.
>
ok, got it.

i sent a new patch to check the bus_type instead :)