linux-kernel - Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170918.093436.1069699729581966538.davem@davemloft.net>
Date:   Mon, 18 Sep 2017 09:34:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rcochran@...utronix.de
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, andre.guedes@...el.com,
        anna-maria@...utronix.de, henrik@...tad.us,
        jesus.sanchez-palencia@...el.com, john.stultz@...aro.org,
        tglx@...utronix.de, vinicius.gomes@...el.com
Subject: Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

From: Richard Cochran <rcochran@...utronix.de>
Date: Mon, 18 Sep 2017 09:41:15 +0200

>   - The driver does not handle out of order packets.  If user space
>     sends a packet with an earlier Tx time, then the code should stop
>     the queue, reshuffle the descriptors accordingly, and then
>     restart the queue.

The user should simply be not allowed to do this.

Once the packet is in the device queue, that's it.  You cannot insert
a new packet to be transmitted before an already hw queued packet,
period.

Any out of order request should be rejected with an error.

I'd say the same is true for requests to send packets timed
in the past.