linux-kernel - Re: [PATCH RFC V1 net-next 1/6] net: Add a new socket option for a future transmit time.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1505747934.29839.21.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Mon, 18 Sep 2017 08:18:54 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Richard Cochran <rcochran@...utronix.de>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org,
        Andre Guedes <andre.guedes@...el.com>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        David Miller <davem@...emloft.net>,
        Henrik Austad <henrik@...tad.us>,
        Jesus Sanchez-Palencia <jesus.sanchez-palencia@...el.com>,
        John Stultz <john.stultz@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: Re: [PATCH RFC V1 net-next 1/6] net: Add a new socket option for a
 future transmit time.

On Mon, 2017-09-18 at 09:41 +0200, Richard Cochran wrote:

> +	case SO_TXTIME:
> +		if (!sock_flag(sk, SOCK_TXTIME))
> +			return -EINVAL;
> +		sockc->transmit_time = *(u64 *)CMSG_DATA(cmsg);

1) No guarantee the CMSG is properly aligned on arches that might trap
on unaligned access.

2) No guarantee user provided 8 bytes here.

Also, what would be the time base here ?

> +		break;
>  	/* SCM_RIGHTS and SCM_CREDENTIALS are semantically in SOL_UNIX. */
>  	case SCM_RIGHTS:
>  	case SCM_CREDENTIALS: