linux-kernel - Re: [PATCH v2] ARC: reset: introduce AXS10x reset driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2017 18:51:24 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Vineet Gupta <Vineet.Gupta1@...opsys.com>,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
Cc:     linux-snps-arc@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2] ARC: reset: introduce AXS10x reset driver

Hi Vineet,

On Mon, 2017-09-18 at 09:14 -0700, Vineet Gupta wrote:
> Hi Philipp,
> 
> On 09/18/2017 05:07 AM, Philipp Zabel wrote:
> > On Thu, 2017-09-14 at 17:28 +0300, Eugeniy Paltsev wrote:
> > > ARC AXS10x boards support custom IP-block which allows to control
> > > reset signals of selected peripherals. For example DW GMAC, etc...
> > > This block is controlled via memory-mapped register (AKA CREG) which
> > > represents up-to 32 reset lines. This regiter is self-clearing so we
> > > don't need to deassert line after reset.
> > > 
> > > As of today only the following lines are used:
> > >   - DW GMAC - line 5
> > > 
> > > > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
> > > 
> > > ---
> > > Changes v1 -> v2:
> > >    * The creg reset register is self-clearing so we don't need to clear it
> > >      manually. Fixed it.
> > >    * Use reset callback instead of assert/deassert pair.
> > >    * Rename reset node in documentation to "reset-controller" for consistency
> > >      with the other bindings.
> > >    * Use devm_reset_controller_register instead of reset_controller_register
> > > 
> > > NOTE:
> > >      This driver couldn't be replaced by reset-simple driver as we mustn't
> > >      read from reset register or clear it.
> > 
> > Thanks, I've applied this patch to the reset/next branch.
> 
> Will it be OK for you to apply the corresponding DT update for platform - that way 
> I don't have to keep track of when ur branch hits mainline etc.
> 
> The chances of any ensuing conflicts are pretty rare - and easy to resolve if at all.
>
> If so, Eugeniy can send the patch ur way !

Maybe it is better to do this the other way around? I can put this patch
on a stable reset/arc branch for you to merge before applying the reset
DT updates.

regards
Philipp