lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Sep 2017 11:46:18 -0600 From: Shuah Khan <shuah@...nel.org> To: josef@...icpanda.com Cc: Josef Bacik <jbacik@...com>, "David S. Miller" <davem@...emloft.net>, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, netdev@...r.kernel.org, shuah Khan <shuahkh@....samsung.com> Subject: Re: [PATCH 3/3] selftests: silence test output by default On 09/18/2017 11:37 AM, josef@...icpanda.com wrote: > From: Josef Bacik <jbacik@...com> > > Some of the networking tests are very noisy and make it impossible to > see if we actually passed the tests as they run. Default to suppressing > the output from any tests run in order to make it easier to track what > failed. > > Signed-off-by: Josef Bacik <jbacik@...com> > -- This change suppresses pass/fail wrapper output for all tests, not just the networking tests. Could you please send me before and after results for what you are trying to fix. > tools/testing/selftests/lib.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index 693616651da5..223234cd98e9 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -24,7 +24,7 @@ define RUN_TESTS > echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\ > echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [FAIL]"; \ > else \ > - cd `dirname $$TEST` > /dev/null; (./$$BASENAME_TEST && echo "ok 1..$$test_num selftests: $$BASENAME_TEST [PASS]") || echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [FAIL]"; cd - > /dev/null;\ > + cd `dirname $$TEST` > /dev/null; (./$$BASENAME_TEST > /dev/null 2>&1 && echo "ok 1..$$test_num selftests: $$BASENAME_TEST [PASS]") || echo "not ok 1..$$test_num selftests: $$BASENAME_TEST [FAIL]"; cd - > /dev/null;\ > fi; \ > done; > endef > @@ -55,7 +55,7 @@ endif > define EMIT_TESTS > @for TEST in $(TEST_GEN_PROGS) $(TEST_PROGS); do \ > BASENAME_TEST=`basename $$TEST`; \ > - echo "(./$$BASENAME_TEST && echo \"selftests: $$BASENAME_TEST [PASS]\") || echo \"selftests: $$BASENAME_TEST [FAIL]\""; \ > + echo "(./$$BASENAME_TEST > /dev/null 2>&1 && echo \"selftests: $$BASENAME_TEST [PASS]\") || echo \"selftests: $$BASENAME_TEST [FAIL]\""; \ > done; > endef > > thanks, -- Shuah
Powered by blists - more mailing lists