lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Sep 2017 13:52:56 -0400 From: Josef Bacik <josef@...icpanda.com> To: Shuah Khan <shuah@...nel.org> Cc: josef@...icpanda.com, Josef Bacik <jbacik@...com>, "David S. Miller" <davem@...emloft.net>, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, netdev@...r.kernel.org, shuah Khan <shuahkh@....samsung.com> Subject: Re: [PATCH 3/3] selftests: silence test output by default On Mon, Sep 18, 2017 at 11:46:18AM -0600, Shuah Khan wrote: > On 09/18/2017 11:37 AM, josef@...icpanda.com wrote: > > From: Josef Bacik <jbacik@...com> > > > > Some of the networking tests are very noisy and make it impossible to > > see if we actually passed the tests as they run. Default to suppressing > > the output from any tests run in order to make it easier to track what > > failed. > > > > Signed-off-by: Josef Bacik <jbacik@...com> > > -- > > This change suppresses pass/fail wrapper output for all tests, not just the > networking tests. > > Could you please send me before and after results for what you are trying > to fix. > Yeah I wanted to suppress extraneous output from everybody, I just happened to notice it because I was testing net. The default thing already spits out what it's running and pass/fail, there's no need to include all of the random output unless the user wants to go and run the test manually. As it is now it's _impossible_ to tell what ran and what passed/failed because of all the random output. Ideally kselftests would work like xfstests does and simply capture the output to a log so you could go check afterwards, but that's a lot more work. Making it easier to tell which tests passed/failed is a good enough first step. Thanks, Josef
Powered by blists - more mailing lists