linux-kernel - Re: linux-4.14-rc1/arch/x86/include/asm/uaccess.h: Missing include of <linux/sched.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170919131234.7eznipb6b76lwo7u@macchiaveli>
Date:   Tue, 19 Sep 2017 15:12:34 +0200
From:   Seraphime Kirkovski <kirkseraph@...il.com>
To:     Stefan Mätje <Stefan.Maetje@....eu>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-4.14-rc1/arch/x86/include/asm/uaccess.h: Missing include
 of <linux/sched.h>

Hi,

> ./arch/x86/include/asm/uaccess.h: In function ‘set_fs’:
> ./arch/x86/include/asm/uaccess.h:31:9: error: dereferencing pointer to
> incomplete type

I can reproduce your problem by including <asm/uaccess.h>, but not with 
<linux/uaccess.h>.

	#include <asm/uaccess.h>
	//#include <linux/uaccess.h> does compile
	#include <linux/module.h>


	int __init init(void)
	{
		set_fs(get_fs());
		return 0;
	}

	void __exit finit(void)
	{
	}

	module_init(init);
	module_exit(finit);

If my memory is any good, direct inclusion of <asm/uaccess.h> was 
deprecated in 4.12 and new code should use <linux/uaccess.h>

Thanks,
Seraphime Kirkovski