linux-kernel - Re: linux-4.14-rc1/arch/x86/include/asm/uaccess.h: Missing include of <linux/sched.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1017211f-607c-56fa-104f-0b1f49ebac40@esd.eu>
Date:   Tue, 19 Sep 2017 15:57:05 +0200
From:   Stefan Mätje <Stefan.Maetje@....eu>
To:     Seraphime Kirkovski <kirkseraph@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-4.14-rc1/arch/x86/include/asm/uaccess.h: Missing include of
 <linux/sched.h>

Hi,

changing the include line to <linux/uaccess.h> solves the problem for me.

Thank you for taking the time to look into this.

Best regards,
	Stefan Mätje

Am 19.09.2017 um 15:12 schrieb Seraphime Kirkovski:
> Hi,
> 
>> ./arch/x86/include/asm/uaccess.h: In function ‘set_fs’:
>> ./arch/x86/include/asm/uaccess.h:31:9: error: dereferencing pointer to
>> incomplete type
> 
> I can reproduce your problem by including <asm/uaccess.h>, but not with 
> <linux/uaccess.h>.
> 
> 	#include <asm/uaccess.h>
> 	//#include <linux/uaccess.h> does compile
> 	#include <linux/module.h>

My code doesn't use set_fs() but it is only in the header.

> If my memory is any good, direct inclusion of <asm/uaccess.h> was 
> deprecated in 4.12 and new code should use <linux/uaccess.h>

I did miss this deprecation.

> Thanks,
> Seraphime Kirkovski
>