linux-kernel - Re: [PATCH 2/3] kcov: remove pointless current != NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170919133237.GF30715@leverpostej>
Date:   Tue, 19 Sep 2017 14:32:37 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc:     Dmitry Vyukov <dvyukov@...gle.com>, akpm@...ux-foundation.org,
        Andrey Konovalov <andreyknvl@...gle.com>, tchibo@...gle.com,
        syzkaller@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] kcov: remove pointless current != NULL check

On Tue, Sep 19, 2017 at 03:46:47PM +0300, Andrey Ryabinin wrote:
> __sanitizer_cov_trace_pc() is a hot code, so it's worth
> to remove pointless '!current' check. Current is never NULL.
> 
> Signed-off-by: Andrey Ryabinin <aryabinin@...tuozzo.com>

Acked-by: Mark Rutland <mark.rutland@....com>

Thanks,
Mark.

> ---
>  kernel/kcov.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/kcov.c b/kernel/kcov.c
> index 2f0e7a7c7afc..14cc8c1a7cad 100644
> --- a/kernel/kcov.c
> +++ b/kernel/kcov.c
> @@ -61,7 +61,7 @@ void notrace __sanitizer_cov_trace_pc(void)
>  	 * We are interested in code coverage as a function of a syscall inputs,
>  	 * so we ignore code executed in interrupts.
>  	 */
> -	if (!t || !in_task())
> +	if (!in_task())
>  		return;
>  	mode = READ_ONCE(t->kcov_mode);
>  	if (mode == KCOV_MODE_TRACE) {
> -- 
> 2.13.5
>