linux-kernel - Re: [PATCH 2/2] libnvdimm, namespace: fix btt claim class crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1505858348.3864.8.camel@hpe.com>
Date:   Tue, 19 Sep 2017 22:06:21 +0000
From:   "Saldivar, Maurice A." <maurice.a.saldivar@....com>
To:     "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "vishal.l.verma@...el.com" <vishal.l.verma@...el.com>
Subject: Re: [PATCH 2/2] libnvdimm, namespace: fix btt claim class crash

I applied this and the kernel patch and was successfully able to
configure an NVDIMM-N into sector mode. I do have a question about
specific behavior I observed. Before I was able to configure an NVDIMM
into any mode from any mode. With these patchs if I go to sector mode
and try going to memory or dax mode it fails with: 

# ndctl create-namespace -f -e namespace0.0 -m memory
  Error: namespace0.0: sector_size: 4096 not supported
failed to reconfigure namespace: Invalid argument
 
but if I go sector->raw-><mode> I can get into other modes fine. Was
this the intended behavior? 

Sincerely, 
Maurice  

On Tue, 2017-09-19 at 12:51 -0700, Dan Williams wrote:
> Maurice reports:
> 
>     BUG: unable to handle kernel NULL pointer dereference at
> 0000000000000028
>     IP: holder_class_store+0x253/0x2b0 [libnvdimm]
> 
> ...while trying to reconfigure an NVDIMM-N namespace into 'sector' /
> 'btt' mode. The crash points to this line:
> 
>     (gdb) li *(holder_class_store+0x253)
>     0x7773 is in holder_class_store
> (drivers/nvdimm/namespace_devs.c:1420).
>     1415            for (i = 0; i < nd_region->ndr_mappings; i++) {
>     1416                    struct nd_mapping *nd_mapping =
> &nd_region->mapping[i];
>     1417                    struct nvdimm_drvdata *ndd =
> to_ndd(nd_mapping);
>     1418                    struct nd_namespace_index *nsindex;
>     1419
>     1420                    nsindex = to_namespace_index(ndd, ndd-
> >ns_current);
> 
> ...where we are failing because ndd is NULL due to NVDIMM-N dimms not
> supporting labels.
> 
> Long story short, default to the BTTv1 format in the label-less /
> NVDIMM-N case.
> 
> Fixes: 14e494542636 ("libnvdimm, btt: BTT updates for UEFI 2.7
> format")
> Cc: <stable@...r.kernel.org>
> Cc: Vishal Verma <vishal.l.verma@...el.com>
> Reported-by: Maurice A. Saldivar <maurice.a.saldivar@....com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> ---
>  drivers/nvdimm/namespace_devs.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/nvdimm/namespace_devs.c
> b/drivers/nvdimm/namespace_devs.c
> index 1427a386a033..3e4d1e7998da 100644
> --- a/drivers/nvdimm/namespace_devs.c
> +++ b/drivers/nvdimm/namespace_devs.c
> @@ -1417,6 +1417,15 @@ static int btt_claim_class(struct device *dev)
>  		struct nvdimm_drvdata *ndd = to_ndd(nd_mapping);
>  		struct nd_namespace_index *nsindex;
>  
> +		/*
> +		 * If any of the DIMMs do not support labels the
> only
> +		 * possible BTT format is v1.
> +		 */
> +		if (!ndd) {
> +			loop_bitmask = 0;
> +			break;
> +		}
> +
>  		nsindex = to_namespace_index(ndd, ndd->ns_current);
>  		if (nsindex == NULL)
>  			loop_bitmask |= 1;
>