linux-kernel - Re: [PATCH v2] Makefile: kselftest and kselftest-clean fail for make O=dir case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Sep 2017 10:14:38 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Shuah Khan <shuahkh@....samsung.com>
Cc:     Michal Marek <mmarek@...e.com>, shuah@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Bamvor Zhang Jian <bamvor.zhangjian@...aro.org>,
        emilio.lopez@...labora.co.uk, Jonathan Corbet <corbet@....net>,
        "Theodore Ts'o" <tytso@....edu>, ebiederm@...ssion.com,
        Tim.Bird@...y.com, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2] Makefile: kselftest and kselftest-clean fail for make
 O=dir case

2017-09-21 2:32 GMT+09:00 Shuah Khan <shuahkh@....samsung.com>:
> kselftest and kselftest-clean targets fail when object directory is
> specified to relocate objects. Fix it so it can find the source tree
> to build from.
>
> make O=/tmp/kselftest_top kselftest
>
> make[1]: Entering directory '/tmp/kselftest_top'
> make[2]: Entering directory '/tmp/kselftest_top'
> make[2]: *** tools/testing/selftests: No such file or directory.  Stop.
> make[2]: Leaving directory '/tmp/kselftest_top'
> ./linux-kselftest/Makefile:1185: recipe for target
> 'kselftest' failed
> make[1]: *** [kselftest] Error 2
> make[1]: Leaving directory '/tmp/kselftest_top'
> Makefile:145: recipe for target 'sub-make' failed
> make: *** [sub-make] Error 2
>
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
> Changes v1 - V2: Simplify logic - use $(srctree)
>
>  Makefile | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 64cbc66cebca..7735fc32b24e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1169,14 +1169,13 @@ headers_check: headers_install
>
>  # ---------------------------------------------------------------------------
>  # Kernel selftest
> -
>  PHONY += kselftest
>  kselftest:
> -       $(Q)$(MAKE) -C tools/testing/selftests run_tests
> +       $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests
>
>  PHONY += kselftest-clean
>  kselftest-clean:
> -       $(Q)$(MAKE) -C tools/testing/selftests clean
> +       $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean
>
>  PHONY += kselftest-merge
>  kselftest-merge:
> --

Acked-by: Masahiro Yamada <yamada.masahiro@...ionext.com>




-- 
Best Regards
Masahiro Yamada