linux-kernel - Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170921151744.000054d0@huawei.com>
Date:   Thu, 21 Sep 2017 15:17:44 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
CC:     <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-renesas-soc@...r.kernel.org>, <linux-iio@...r.kernel.org>,
        <linux-input@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>
Subject: Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE

On Wed, 20 Sep 2017 20:59:56 +0200
Wolfram Sang <wsa+renesas@...g-engineering.com> wrote:

> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Makes sense as do the other drivers.

Feel free to add

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

to all of them (though they hardly took a lot of reviewing given how simple
the patches were :)

> ---
>  drivers/i2c/i2c-dev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
> index 6f638bbc922db4..bbc7aadb4c899d 100644
> --- a/drivers/i2c/i2c-dev.c
> +++ b/drivers/i2c/i2c-dev.c
> @@ -280,6 +280,8 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client,
>  			res = PTR_ERR(rdwr_pa[i].buf);
>  			break;
>  		}
> +		/* memdup_user allocates with GFP_KERNEL, so DMA is ok */
> +		rdwr_pa[i].flags |= I2C_M_DMA_SAFE;
>  
>  		/*
>  		 * If the message length is received from the slave (similar