linux-kernel - Re: [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3E24DF8F-A2D4-493C-AA9F-DC3EFC2E6364@lightnvm.io>
Date:   Fri, 22 Sep 2017 12:03:14 +0200
From:   Javier González <jg@...htnvm.io>
To:     Rakesh Pandit <rakesh@...era.com>
Cc:     Matias Bjørling <mb@...htnvm.io>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] lightnvm: pblk: fix message if L2P MAP is in device

Sure.

Matias: Can you fix this when picking it up?

Javier

> On 22 Sep 2017, at 11.44, Rakesh Pandit <rakesh@...era.com> wrote:
> 
> On Fri, Sep 22, 2017 at 10:52:19AM +0200, Javier González wrote:
>>> On 21 Sep 2017, at 13.26, Rakesh Pandit <rakesh@...era.com> wrote:
>>> 
>>> This usually happens if we are developing with qemu and ll2pmode has
>>> default value.  Even in that case message seems wrong.
>>> 
>>> Signed-off-by: Rakesh Pandit <rakesh@...era.com>
>>> ---
>>> drivers/lightnvm/pblk-init.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
>>> index 470ef04..c5c1337 100644
>>> --- a/drivers/lightnvm/pblk-init.c
>>> +++ b/drivers/lightnvm/pblk-init.c
>>> @@ -913,7 +913,7 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk,
>>> 	int ret;
>>> 
>>> 	if (dev->identity.dom & NVM_RSP_L2P) {
>>> -		pr_err("pblk: device-side L2P table not supported. (%x)\n",
>>> +		pr_err("pblk: device-side L2P table supported. (%x)\n",
>>> 							dev->identity.dom);
>>> 		return ERR_PTR(-EINVAL);
>>> 	}
>>> --
>>> 2.5.0
>> 
>> You're right. This is inherited from rrpc.
>> 
>> Can we instead write "pblk: full host-side L2P table not supported"?
>> People will not know about the hybrid device/host L2P as time goes by
>> and it will just be confusing. I'm not even sure this will be part of
>> the 2.0 spec, so it will probably go away with time...
> 
> Sure.  I was confused the first time.  This is better.
> 
> It would be great if this is done while picking up.  I can repost as
> well if need be.
> 
> Thanks,

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)