linux-kernel - Re: [RFC][PATCH] sched: Cleanup task->state printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Sep 2017 17:56:40 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Markus Trippelsdorf <markus@...ppelsdorf.de>,
        Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [RFC][PATCH] sched: Cleanup task->state printing

On Fri, Sep 22, 2017 at 10:12:45AM -0400, Steven Rostedt wrote:
> On Fri, 22 Sep 2017 13:54:30 +0200
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > I should probably split this thing into a bunch of patches :/
> 
> Yes please. Convert form dec to hex in one patch and one patch only.

Yeah, was already on it, did more cleanups too.

> Because I'm not sure if you meant to change numbers or not.
> 
> 
> >  /* Used in tsk->state again: */
> > -#define TASK_DEAD			64
> > -#define TASK_WAKEKILL			128
> > -#define TASK_WAKING			256
> > -#define TASK_PARKED			512
> > -#define TASK_NOLOAD			1024
> > -#define TASK_NEW			2048
> > -#define TASK_STATE_MAX			4096
> > +#define TASK_PARKED			0x0040
> > +#define TASK_REPORT_MAX			0x0080
> >  
> > -#define TASK_STATE_TO_CHAR_STR		"RSDTtXZxKWPNn"
> > +/* Not in TASK_REPORT: */
> > +#define TASK_DEAD			0x0080
> 
> TASK_DEAD went from 64 to 128 (0x40 to 0x80)
> 
> As well as all the defines below that. Was this on purpose?

Yes, was on purpose. I moved TASK_PARKED up, such that I could include
it in the TASK_REPORT mask and keep that contiguous.