linux-kernel - Re: [PATCH 4/6] lightnvm: pblk: improve error message if down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55dfff8b-6e74-89bb-7c3f-1286cb4ea914@lightnvm.io>
Date:   Mon, 25 Sep 2017 12:15:11 +0200
From:   Matias Bjørling <mb@...htnvm.io>
To:     Javier González <jg@...htnvm.io>,
        Rakesh Pandit <rakesh@...era.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] lightnvm: pblk: improve error message if down_timeout
 fails

On 09/22/2017 10:55 AM, Javier González wrote:
>> On 21 Sep 2017, at 13.27, Rakesh Pandit <rakesh@...era.com> wrote:
>>
>> The two pr_err messages are useless as they don't even differentiate
>> error code.
>>
>> Signed-off-by: Rakesh Pandit <rakesh@...era.com>
>> ---
>> drivers/lightnvm/pblk-core.c | 12 ++----------
>> 1 file changed, 2 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>> index b92eabc..74ddb30 100644
>> --- a/drivers/lightnvm/pblk-core.c
>> +++ b/drivers/lightnvm/pblk-core.c
>> @@ -1734,16 +1734,8 @@ static void __pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list,
>> #endif
>>
>> 	ret = down_timeout(&rlun->wr_sem, msecs_to_jiffies(30000));
>> -	if (ret) {
>> -		switch (ret) {
>> -		case -ETIME:
>> -			pr_err("pblk: lun semaphore timed out\n");
>> -			break;
>> -		case -EINTR:
>> -			pr_err("pblk: lun semaphore timed out\n");
>> -			break;
>> -		}
>> -	}
>> +	if (ret == -ETIME || ret == -EINTR)
>> +		pr_err("pblk: taking lun semaphore timed out: err %d\n", -ret);
>> }
>>
>> void pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas)
>> --
>> 2.5.0
> 
> Looks good.
> 
> 
> Reviewed-by: Javier González <javier@...xlabs.com>
> 
Thanks, I picked it up.