linux-kernel - Re: [PATCH 4/4] pid: Remove pidhash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Sep 2017 09:48:29 -0400
From:   Rik van Riel <riel@...riel.com>
To:     Gargi Sharma <gs051095@...il.com>, linux-kernel@...r.kernel.org
Cc:     julia.lawall@...6.fr, akpm@...ux-foundation.org, mingo@...nel.org,
        pasha.tatashin@...cle.com, ktkhai@...tuozzo.com, oleg@...hat.com
Subject: Re: [PATCH 4/4] pid: Remove pidhash

On Mon, 2017-09-25 at 08:56 -0400, Gargi Sharma wrote:
> pidhash is no longer required as all the information
> can be looked up from idr tree. Also, nr_hashed represented
> the number of pids that had been hashed. Since, nr_hashed is
> no longer relevant, it has been renamed to pid_allocated.
> 
> Signed-off-by: Gargi Sharma <gs051095@...il.com>

> @@ -66,7 +59,7 @@ int pid_max_max = PID_MAX_LIMIT;
>  struct pid_namespace init_pid_ns = {
>  	.kref = KREF_INIT(2),
>  	.idr = IDR_INIT,
> -	.nr_hashed = PIDNS_HASH_ADDING,
> +	.pid_allocated = PIDNS_HASH_ADDING,
>  	.level = 0,
>  	.child_reaper = &init_task,
>  	.user_ns = &init_user_ns,
> 

Should PIDNS_HASH_ADDING be renamed too, now that the pidhash is
gone?

Not that I have any ideas for a better name. This patch looks good
to me. Feel free to add this line the next time you submit it:

Reviewed-by: Rik van Riel <riel@...hat.com>

-- 
All Rights Reversed.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)