linux-kernel - Re: [PATCH v2 2/3] KEYS: don't revoke uninstantiated key in request_key_auth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30194.1506348893@warthog.procyon.org.uk>
Date:   Mon, 25 Sep 2017 15:14:53 +0100
From:   David Howells <dhowells@...hat.com>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     dhowells@...hat.com, keyrings@...r.kernel.org,
        Michael Halcrow <mhalcrow@...gle.com>,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH v2 2/3] KEYS: don't revoke uninstantiated key in request_key_auth_new()

Eric Biggers <ebiggers3@...il.com> wrote:

> Fix this by removing the call to key_revoke().  key_put() is sufficient,
> as it's not possible for an uninstantiated authkey to have been used for
> anything yet.

Note that the owner can call keyctl_describe() upon it, though that shouldn't
wait because KEY_LOOKUP_PARTIAL would be specified.

However, this is probably fair enough, and it should be gc'd quickly because
it'll lose its last ref.

David