linux-kernel - Re: [PATCH v2 1/3] KEYS: fix cred refcount leak in request_key_auth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30852.1506349137@warthog.procyon.org.uk>
Date:   Mon, 25 Sep 2017 15:18:57 +0100
From:   David Howells <dhowells@...hat.com>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     dhowells@...hat.com, keyrings@...r.kernel.org,
        Michael Halcrow <mhalcrow@...gle.com>,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH v2 1/3] KEYS: fix cred refcount leak in request_key_auth_new()

Eric Biggers <ebiggers3@...il.com> wrote:

> +	rka = kzalloc(sizeof(*rka), GFP_KERNEL);
> +	if (!rka)
> +		goto error_free_rka;

But you haven't allocated an rka if you're in the error path.  I'll fix that
to jump over the release.

David