linux-kernel - Re: [PATCH v3] staging: greybus: light: Release memory obtained by kasprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170925141921.GA21407@arch-late.localdomain>
Date:   Mon, 25 Sep 2017 15:19:21 +0100
From:   Rui Miguel Silva <rmfrfs@...il.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     johan@...nel.org, elder@...nel.org, gregkh@...uxfoundation.org,
        greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: greybus: light: Release memory obtained by
 kasprintf

Hi,
On Sat, Sep 23, 2017 at 01:25:30PM +0530, Arvind Yadav wrote:
> Free memory region, if gb_lights_channel_config is not successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Thanks for the patch, looks good to me.

Reviewed-by: Rui Miguel Silva <rmfrfs@...il.com>

---
Cheers,
	Rui

> ---
> changes in v2:
>             - Subject line changed.
>             - add kfree in __gb_lights_led_unregister().
>             - No need to check return value of gb_lights_channel_flash_config().
> 
> changes ib v3:
>             - separate patch for "No need to check return value of
>               gb_lights_channel_flash_config()".
> 
>  drivers/staging/greybus/light.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index 3f4148c..0f538b8 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -925,6 +925,8 @@ static void __gb_lights_led_unregister(struct gb_channel *channel)
>  		return;
>  
>  	led_classdev_unregister(cdev);
> +	kfree(cdev->name);
> +	cdev->name = NULL;
>  	channel->led = NULL;
>  }
>  
> -- 
> 2.7.4
>