linux-kernel - Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <faf455ad-b7ef-beac-ac6d-4822f350cd71@infradead.org>
Date:   Mon, 25 Sep 2017 15:32:56 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>
Cc:     Mark Brown <broonie@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        Baolin Wang <Baolin.Wang@...eadtrum.com>
Subject: Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when
 SPI_SPRD_ADI=y and HWSPINLOCK=m

On 09/25/17 14:11, Mark Brown wrote:
> On Mon, Sep 25, 2017 at 12:53:20PM -0700, Randy Dunlap wrote:
>> On 09/25/17 12:44, Mark Brown wrote:
> 
>>> That would then get in the way of build test coverage.  
> 
>> I don't agree, but whatever. I give up.
> 
> OK.  Just as a general thing it's really important that dependency
> changes be thought through and express what the constraints are in ways
> that reflect what's actually going on and what's useful for users, it
> seems to be a frequent problem and it does get in the way.

Yes, it's a frequent problem that drivers do not build due to some kconfig
dependency issue(s).

I would prefer to see the driver maintainer(s) fix build errors themselves,
but they are not always aware of the idiosyncrasies of kconfig.

I think that people often submit drivers (or driver changes) after building
it in one (working) configuration only, without regard for the other possible
combinations.


-- 
~Randy