linux-kernel - RE: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device property "size"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7B8CE47BD58441468D2BB13285B50E6031DF0721@BGSMSX107.gar.corp.intel.com>
Date:   Tue, 26 Sep 2017 05:29:06 +0000
From:   "Mohandass, Divagar" <divagar.mohandass@...el.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        "Mani, Rajmohan" <rajmohan.mani@...el.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "wsa@...-dreams.de" <wsa@...-dreams.de>,
        "sakari.ailus@....fi" <sakari.ailus@....fi>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tfiga@...omium.org" <tfiga@...omium.org>
Subject: RE: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device
 property "size"

Hi Andy,

Sorry missed the 'Suggested-by' tag. Can I resend the v6 with this change, so that Wolfram can pick these patches ?

---
^Divagar

>-----Original Message-----
>From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
>Sent: Friday, September 22, 2017 9:42 PM
>To: Mani, Rajmohan <rajmohan.mani@...el.com>
>Cc: Mohandass, Divagar <divagar.mohandass@...el.com>;
>robh+dt@...nel.org; mark.rutland@....com; wsa@...-dreams.de;
>sakari.ailus@....fi; devicetree@...r.kernel.org; linux-i2c@...r.kernel.org;
>linux-kernel@...r.kernel.org; tfiga@...omium.org
>Subject: Re: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom
>device property "size"
>
>On Wed, Sep 20, 2017 at 6:52 AM, Mani, Rajmohan
><rajmohan.mani@...el.com> wrote:
>> Adding Tomasz...
>
>Please, don't top post.
>Better to resend entire series with all stakeholders included.
>
>>> Obtain the size of the EEPROM chip from DT if the "size" property is
>>> specified for the device.
>>>
>
>I guess it lacks
>Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
>Other than that, looks good to me!
>
>Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
>
>
>Wolfram, the binding is ACKed by Rob and this one is in a good shape.
>Moreover, it seems like a demand for the property since some IoT stuff
>would like to use the driver on ACPI enabled platforms with different sizes.
>
>Can you go ahead and apply first two patches? It would be really appreciated.
>
>>> Signed-off-by: Divagar Mohandass <divagar.mohandass@...el.com>
>>> ---
>>>  drivers/misc/eeprom/at24.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
>>> index
>>> 764ff5df..2199c42 100644
>>> --- a/drivers/misc/eeprom/at24.c
>>> +++ b/drivers/misc/eeprom/at24.c
>>> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev,
>>> struct at24_platform_data *chip)
>>>       if (device_property_present(dev, "read-only"))
>>>               chip->flags |= AT24_FLAG_READONLY;
>>>
>>> +     err = device_property_read_u32(dev, "size", &val);
>>> +     if (!err)
>>> +             chip->byte_len = val;
>>> +
>>>       err = device_property_read_u32(dev, "pagesize", &val);
>>>       if (!err) {
>>>               chip->page_size = val;
>>> --
>>> 1.9.1
>>
>
>
>
>--
>With Best Regards,
>Andy Shevchenko