linux-kernel - Re: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device property "size"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve_1oRe6w_yyQW_76NHf-boF+VqYNenTKit0PJPFj+N7A@mail.gmail.com>
Date:   Fri, 22 Sep 2017 19:11:40 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Mani, Rajmohan" <rajmohan.mani@...el.com>
Cc:     "Mohandass, Divagar" <divagar.mohandass@...el.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "wsa@...-dreams.de" <wsa@...-dreams.de>,
        "sakari.ailus@....fi" <sakari.ailus@....fi>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tfiga@...omium.org" <tfiga@...omium.org>
Subject: Re: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device
 property "size"

On Wed, Sep 20, 2017 at 6:52 AM, Mani, Rajmohan <rajmohan.mani@...el.com> wrote:
> Adding Tomasz...

Please, don't top post.
Better to resend entire series with all stakeholders included.

>> Obtain the size of the EEPROM chip from DT if the "size" property is specified
>> for the device.
>>

I guess it lacks
Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Other than that, looks good to me!

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>


Wolfram, the binding is ACKed by Rob and this one is in a good shape.
Moreover, it seems like a demand for the property since some IoT stuff
would like to use the driver on ACPI enabled platforms with different
sizes.

Can you go ahead and apply first two patches? It would be really appreciated.

>> Signed-off-by: Divagar Mohandass <divagar.mohandass@...el.com>
>> ---
>>  drivers/misc/eeprom/at24.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index
>> 764ff5df..2199c42 100644
>> --- a/drivers/misc/eeprom/at24.c
>> +++ b/drivers/misc/eeprom/at24.c
>> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct
>> at24_platform_data *chip)
>>       if (device_property_present(dev, "read-only"))
>>               chip->flags |= AT24_FLAG_READONLY;
>>
>> +     err = device_property_read_u32(dev, "size", &val);
>> +     if (!err)
>> +             chip->byte_len = val;
>> +
>>       err = device_property_read_u32(dev, "pagesize", &val);
>>       if (!err) {
>>               chip->page_size = val;
>> --
>> 1.9.1
>



-- 
With Best Regards,
Andy Shevchenko