linux-kernel - Re: [Part1 PATCH v4 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dcafa981-9678-8ea2-4249-bcec57521da4@amd.com>
Date:   Tue, 26 Sep 2017 14:06:08 -0500
From:   Brijesh Singh <brijesh.singh@....com>
To:     Borislav Petkov <bp@...e.de>
Cc:     brijesh.singh@....com, linux-kernel@...r.kernel.org,
        x86@...nel.org, kvm@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [Part1 PATCH v4 02/17] x86/mm: Add Secure Encrypted
 Virtualization (SEV) support



On 09/17/2017 09:02 AM, Borislav Petkov wrote:
...

>>   
>> +unsigned int sev_enabled __section(.data) = 0;
> 
> static.
> 

Will covert to static in next rev.

...

> 
>> -static inline u64 sme_get_me_mask(void)
>> +static inline bool mem_encrypt_active(void)
>>   {
>> -	return sme_me_mask;
>> +	return !!sme_me_mask;
> 
> As before, you don't need the !!.
> 

Will fix in next rev.
  

thanks