linux-kernel - Re: [Part1 PATCH v4 13/17] x86/io: Unroll string I/O when SEV is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aa2ff15-771c-388d-a443-486808d9ae3f@amd.com>
Date:   Tue, 26 Sep 2017 14:08:35 -0500
From:   Brijesh Singh <brijesh.singh@....com>
To:     Borislav Petkov <bp@...e.de>
Cc:     brijesh.singh@....com, linux-kernel@...r.kernel.org,
        x86@...nel.org, kvm@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Tom Lendacky <thomas.lendacky@....com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        David Laight <David.Laight@...LAB.COM>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [Part1 PATCH v4 13/17] x86/io: Unroll string I/O when SEV is
 active



On 09/17/2017 10:08 AM, Borislav Petkov wrote:
...

>> +
>> +extern struct static_key_false __sev;
>> +static inline bool __sev_active(void)
>> +{
>> +	return static_branch_unlikely(&__sev);
>> +}
> 
> I'm still not happy about the two's sev_active() and __sev_active()
> naming. Perhaps the __ variant should be called sev_key_active() or ...
> 

Will rename it to sev_key_active() in next rev.

-Brijesh