linux-kernel - Re: [PATCH] scsi: ufs: fix wrong command type of UTRD for UFSHCI v2.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <853cb73a8e7139304bedfc8b59d5b710@codeaurora.org>
Date:   Tue, 26 Sep 2017 14:50:41 -0700
From:   Subhash Jadavani <subhashj@...eaurora.org>
To:     kehuanlin <chgokhl@...il.com>
Cc:     vinholikatti@...il.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, kehuanlin@...econe.net,
        linux-scsi-owner@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs: fix wrong command type of UTRD for UFSHCI v2.1

On 2017-09-06 02:58, kehuanlin wrote:
> Since the command type of UTRD in UFS 2.1 specification is the same 
> with
> UFS 2.0. And it assumes the future UFS specification will follow the 
> same
> definition.
> 
> Signed-off-by: kehuanlin <kehuanlin@...econe.net>
> ---
>  drivers/scsi/ufs/ufshcd.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 5bc9dc1..c33a2f8 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -2195,10 +2195,11 @@ static int ufshcd_comp_devman_upiu(struct
> ufs_hba *hba, struct ufshcd_lrb *lrbp)
>  	u32 upiu_flags;
>  	int ret = 0;
> 
> -	if (hba->ufs_version == UFSHCI_VERSION_20)
> -		lrbp->command_type = UTP_CMD_TYPE_UFS_STORAGE;
> -	else
> +	if ((hba->ufs_version == UFSHCI_VERSION_10) ||
> +	    (hba->ufs_version == UFSHCI_VERSION_11))
>  		lrbp->command_type = UTP_CMD_TYPE_DEV_MANAGE;
> +	else
> +		lrbp->command_type = UTP_CMD_TYPE_UFS_STORAGE;
> 
>  	ufshcd_prepare_req_desc_hdr(lrbp, &upiu_flags, DMA_NONE);
>  	if (hba->dev_cmd.type == DEV_CMD_TYPE_QUERY)
> @@ -2222,10 +2223,11 @@ static int ufshcd_comp_scsi_upiu(struct
> ufs_hba *hba, struct ufshcd_lrb *lrbp)
>  	u32 upiu_flags;
>  	int ret = 0;
> 
> -	if (hba->ufs_version == UFSHCI_VERSION_20)
> -		lrbp->command_type = UTP_CMD_TYPE_UFS_STORAGE;
> -	else
> +	if ((hba->ufs_version == UFSHCI_VERSION_10) ||
> +	    (hba->ufs_version == UFSHCI_VERSION_11))
>  		lrbp->command_type = UTP_CMD_TYPE_SCSI;
> +	else
> +		lrbp->command_type = UTP_CMD_TYPE_UFS_STORAGE;
> 
>  	if (likely(lrbp->cmd)) {
>  		ufshcd_prepare_req_desc_hdr(lrbp, &upiu_flags,

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@...eaurora.org>



-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project