linux-kernel - Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Sep 2017 15:44:16 -0700
From:   Subhash Jadavani <subhashj@...eaurora.org>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     kishon@...com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, linux-arm-msm@...r.kernel.org,
        bjorn.andersson@...aro.org, devicetree@...r.kernel.org,
        jejb@...ux.vnet.ibm.com, vinholikatti@...il.com
Subject: Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers
 HS MODE

On 2017-08-03 23:48, Vivek Gautam wrote:
> Set the phy mode based on the UFS HS PA mode. This lets the
> controller let phy know the mode in which the PHY Adapter is
> running and set the phy rates accordingly.
> 
> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> ---
>  drivers/scsi/ufs/ufs-qcom.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index c87d770b519a..44c21d5818ee 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -273,6 +273,9 @@ static int ufs_qcom_power_up_sequence(struct 
> ufs_hba *hba)
>  	bool is_rate_B = (UFS_QCOM_LIMIT_HS_RATE == PA_HS_MODE_B)
>  							? true : false;
> 
> +	if (is_rate_B)
> +		phy_set_mode(phy, PHY_MODE_UFS_HS_B);
> +
>  	/* Assert PHY reset and apply PHY calibration values */
>  	ufs_qcom_assert_reset(hba);
>  	/* provide 1ms delay to let the reset pulse propagate */

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@...eaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project