linux-kernel - Re: [PATCH] mm: update comments for struct page.mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170926163027.12836f5006745fcf6e59ad24@linux-foundation.org>
Date:   Tue, 26 Sep 2017 16:30:27 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     changbin.du@...el.com
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm: update comments for struct page.mapping

On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@...el.com wrote:

> From: Changbin Du <changbin.du@...el.com>
> 
> The struct page.mapping can NULL or points to one object of type
> address_space, anon_vma or KSM private structure.
> 
> ...
>
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -47,8 +47,8 @@ struct page {
>  						 * inode address_space, or NULL.
>  						 * If page mapped as anonymous
>  						 * memory, low bit is set, and
> -						 * it points to anon_vma object:
> -						 * see PAGE_MAPPING_ANON below.
> +						 * it points to anon_vma object
> +						 * or KSM private structure.
>  						 */
>  		void *s_mem;			/* slab first object */
>  		atomic_t compound_mapcount;	/* first tail page */

Why did you remove the (useful) reference to PAGE_MAPPING_ANON?