lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170927035953.GA13117@intel.com>
Date:   Wed, 27 Sep 2017 11:59:53 +0800
From:   "Du, Changbin" <changbin.du@...el.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     changbin.du@...el.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH] mm: update comments for struct page.mapping

On Tue, Sep 26, 2017 at 04:30:27PM -0700, Andrew Morton wrote:
> On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@...el.com wrote:
> 
> > From: Changbin Du <changbin.du@...el.com>
> > 
> > The struct page.mapping can NULL or points to one object of type
> > address_space, anon_vma or KSM private structure.
> > 
> > ...
> >
> > --- a/include/linux/mm_types.h
> > +++ b/include/linux/mm_types.h
> > @@ -47,8 +47,8 @@ struct page {
> >  						 * inode address_space, or NULL.
> >  						 * If page mapped as anonymous
> >  						 * memory, low bit is set, and
> > -						 * it points to anon_vma object:
> > -						 * see PAGE_MAPPING_ANON below.
> > +						 * it points to anon_vma object
> > +						 * or KSM private structure.
> >  						 */
> >  		void *s_mem;			/* slab first object */
> >  		atomic_t compound_mapcount;	/* first tail page */
> 
> Why did you remove the (useful) reference to PAGE_MAPPING_ANON?

There are two flags now, let me add them back. thanks.

-- 
Thanks,
Changbin Du

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ